diff options
| author | Vasiliy Kulikov <segooon@gmail.com> | 2010-10-17 18:41:24 +0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-11-22 10:43:09 -0800 |
| commit | 6dbb2b0e38a9da9b36b4ab486a5c5f75e31a4c0a (patch) | |
| tree | 68f542c45628604e3f8001fe72913d08c0e27374 | |
| parent | 89f5bcae3a7b0c6c42d77d275a343bcf4cf98c0b (diff) | |
pcmcia: synclink_cs: fix information leak to userland
commit 5b917a1420d3d1a9c8da49fb0090692dc9aaee86 upstream.
Structure new_line is copied to userland with some padding fields unitialized.
It leads to leaking of stack memory.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/char/pcmcia/synclink_cs.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/char/pcmcia/synclink_cs.c b/drivers/char/pcmcia/synclink_cs.c index c240562c218b..1612259fb0c5 100644 --- a/drivers/char/pcmcia/synclink_cs.c +++ b/drivers/char/pcmcia/synclink_cs.c @@ -4287,6 +4287,8 @@ static int hdlcdev_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) if (cmd != SIOCWANDEV) return hdlc_ioctl(dev, ifr, cmd); + memset(&new_line, 0, size); + switch(ifr->ifr_settings.type) { case IF_GET_IFACE: /* return current sync_serial_settings */ |