diff options
| author | Arvind Yadav <arvind.yadav.cs@gmail.com> | 2018-03-06 15:35:43 +0530 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-05-30 07:52:14 +0200 |
| commit | 7c84e5e9c62cec8a3c49bf32ddabf2f285cb371b (patch) | |
| tree | 85a7c5b323a51f31c4c89d8213f6394c2e4e2a0c | |
| parent | 845c2de9578675a0969fd76162b53561938b39aa (diff) | |
workqueue: use put_device() instead of kfree()
[ Upstream commit 537f4146c53c95aac977852b371bafb9c6755ee1 ]
Never directly free @dev after calling device_register(), even
if it returned an error! Always use put_device() to give up the
reference initialized in this function instead.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | kernel/workqueue.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/workqueue.c b/kernel/workqueue.c index d0c6b50792c8..d8a7f8939c81 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -5350,7 +5350,7 @@ int workqueue_sysfs_register(struct workqueue_struct *wq) ret = device_register(&wq_dev->dev); if (ret) { - kfree(wq_dev); + put_device(&wq_dev->dev); wq->wq_dev = NULL; return ret; } |