diff options
| author | Jan Kara <jack@suse.cz> | 2015-06-01 14:52:04 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-07-10 09:45:43 -0700 |
| commit | 99d58a593d56a567284741d532cb2679516b54d0 (patch) | |
| tree | 9cf0f892d4e618936cd89f8e394a37f2744132fa | |
| parent | 0cf10d95efb24cd901897c87218d6fc5dfc735dc (diff) | |
ufs: Fix warning from unlock_new_inode()
commit 12ecbb4b1d765a5076920999298d9625439dbe58 upstream.
Commit e4502c63f56aeca88 (ufs: deal with nfsd/iget races) introduced
unlock_new_inode() call into ufs_add_nondir(). However that function
gets called also from ufs_link() which hands it already initialized
inode and thus unlock_new_inode() complains. The problem is harmless but
annoying.
Fix the problem by opencoding necessary stuff in ufs_link()
Fixes: e4502c63f56aeca887ced37f24e0def1ef11cec8
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | fs/ufs/namei.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/fs/ufs/namei.c b/fs/ufs/namei.c index 65158994af19..3812cf78353f 100644 --- a/fs/ufs/namei.c +++ b/fs/ufs/namei.c @@ -174,7 +174,12 @@ static int ufs_link (struct dentry * old_dentry, struct inode * dir, inode_inc_link_count(inode); ihold(inode); - error = ufs_add_nondir(dentry, inode); + error = ufs_add_link(dentry, inode); + if (error) { + inode_dec_link_count(inode); + iput(inode); + } else + d_instantiate(dentry, inode); unlock_ufs(dir->i_sb); return error; } |