summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2012-05-14 23:56:46 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-05-14 15:43:44 -0700
commitbed861ba2a020c267a987c63aca2705d460f1350 (patch)
tree9368e6a208c3d27cfd5438b5e80f5c04adb5b3e0
parent95f18c0cb2d23f6051fd4f40cc5d0836fdeda08f (diff)
Staging: wlags49_h2: potential NULL dereference
wl_device_dealloc() dereferences the "dev" paramter, so let's move it under the check for NULL. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/wlags49_h2/wl_cs.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/staging/wlags49_h2/wl_cs.c b/drivers/staging/wlags49_h2/wl_cs.c
index 7084f414846e..7c7c77f9c862 100644
--- a/drivers/staging/wlags49_h2/wl_cs.c
+++ b/drivers/staging/wlags49_h2/wl_cs.c
@@ -177,10 +177,9 @@ static void wl_adapter_detach(struct pcmcia_device *link)
if (dev) {
unregister_wlags_sysfs(dev);
unregister_netdev(dev);
+ wl_device_dealloc(dev);
}
- wl_device_dealloc(dev);
-
DBG_LEAVE(DbgInfo);
} /* wl_adapter_detach */
/*============================================================================*/