diff options
| author | John Keeping <john@metanate.com> | 2017-11-27 18:15:40 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-12-14 09:28:15 +0100 |
| commit | 112b8a8f558de4004c2a0f7a6d04aba3520fd4ff (patch) | |
| tree | 8627c0f2cb4db36d334b86191ac1f53837bbaeb9 /Documentation/stable_kernel_rules.txt | |
| parent | 47ab72034e9d7abf4538bf4580610cff8aaa576c (diff) | |
usb: f_fs: Force Reserved1=1 in OS_DESC_EXT_COMPAT
commit a3acc696085e112733d191a77b106e67a4fa110b upstream.
The specification says that the Reserved1 field in OS_DESC_EXT_COMPAT
must have the value "1", but when this feature was first implemented we
rejected any non-zero values.
This was adjusted to accept all non-zero values (while now rejecting
zero) in commit 53642399aa71 ("usb: gadget: f_fs: Fix wrong check on
reserved1 of OS_DESC_EXT_COMPAT"), but that breaks any userspace
programs that worked previously by returning EINVAL when Reserved1 == 0
which was previously the only value that succeeded!
If we just set the field to "1" ourselves, both old and new userspace
programs continue to work correctly and, as a bonus, old programs are
now compliant with the specification without having to fix anything
themselves.
Fixes: 53642399aa71 ("usb: gadget: f_fs: Fix wrong check on reserved1 of OS_DESC_EXT_COMPAT")
Signed-off-by: John Keeping <john@metanate.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'Documentation/stable_kernel_rules.txt')
0 files changed, 0 insertions, 0 deletions