diff options
| author | Sri Krishna chowdary <schowdary@nvidia.com> | 2012-09-11 18:38:04 +0530 |
|---|---|---|
| committer | Dan Willemsen <dwillemsen@nvidia.com> | 2013-09-14 12:34:25 -0700 |
| commit | d10fc26dfeae84e113068c6912f64485c52b05a2 (patch) | |
| tree | 3ac6440d3e03dca21f2908b0666330fa3b5051a1 /arch/arm/mach-tegra/baseband-xmm-power2.c | |
| parent | a8a8c53faa379bd311c4feac6d4ba7242897bd63 (diff) | |
arm: tegra: xmm: fix coverity issue
Fixed NULL dereference by NULL checking.
Bug 1046331
Change-Id: I7d7ca75255ddb86b1f238fed469ac8e727f86a78
Signed-off-by: Sri Krishna chowdary <schowdary@nvidia.com>
Reviewed-on: http://git-master/r/131415
Reviewed-by: Automatic_Commit_Validation_User
Reviewed-by: Sachin Nikam <snikam@nvidia.com>
Reviewed-by: Vinayak Pane <vpane@nvidia.com>
Reviewed-by: Bharat Nihalani <bnihalani@nvidia.com>
Tested-by: Vinayak Pane <vpane@nvidia.com>
Rebase-Id: R05694dd371bb644e43d6455a4e38453a27e47377
Diffstat (limited to 'arch/arm/mach-tegra/baseband-xmm-power2.c')
| -rw-r--r-- | arch/arm/mach-tegra/baseband-xmm-power2.c | 16 |
1 files changed, 6 insertions, 10 deletions
diff --git a/arch/arm/mach-tegra/baseband-xmm-power2.c b/arch/arm/mach-tegra/baseband-xmm-power2.c index a79cd6fb499f..f543c46441a4 100644 --- a/arch/arm/mach-tegra/baseband-xmm-power2.c +++ b/arch/arm/mach-tegra/baseband-xmm-power2.c @@ -1,7 +1,7 @@ /* * arch/arm/mach-tegra/baseband-xmm-power2.c * - * Copyright (C) 2011 NVIDIA Corporation + * Copyright (C) 2011-2012, NVIDIA Corporation. All Rights Reserved. * * This software is licensed under the terms of the GNU General Public * License version 2, as published by the Free Software Foundation, and @@ -132,10 +132,6 @@ static void xmm_power2_step2(struct work_struct *work) pr_info("%s {\n", __func__); - /* check for platform data */ - if (!data || !pdata) - return; - /* wait Y ms */ msleep(Y); @@ -169,10 +165,6 @@ static void xmm_power2_step3(struct work_struct *work) pr_info("%s {\n", __func__); - /* check for platform data */ - if (!data || !pdata) - return; - /* wait 1 sec */ msleep(1000); @@ -262,9 +254,13 @@ static void xmm_power2_work_func(struct work_struct *work) { struct xmm_power_data *data = container_of(work, struct xmm_power_data, work); - struct baseband_power_platform_data *pdata = data->pdata; + struct baseband_power_platform_data *pdata; int err; + if (!data || !data->pdata) + return; + pdata = data->pdata; + pr_debug("%s pdata->state=%d\n", __func__, data->state); switch (data->state) { |