diff options
| author | Ioana Ciornei <ioana.ciornei@nxp.com> | 2019-12-13 13:24:01 +0200 |
|---|---|---|
| committer | Ioana Ciornei <ioana.ciornei@nxp.com> | 2019-12-19 19:34:56 +0200 |
| commit | e41f1a1fa21c8a2d164ac3fd00126ccaf0dad710 (patch) | |
| tree | 5806098ee0c646838f6738378e1dc160d05c5c79 /arch/arm64/boot/dts/freescale/imx8mn.dtsi | |
| parent | a8fd628437a45c4aee643e86bcd264872bc6241e (diff) | |
staging: fsl-dpaa2/mac: do not stop MAC when the net_dev is not up
In case the net_device is not up, there is no need to call
dpmac_mac_stop(). Guard the call by checking the IFF_UP flag.
This patch will also solve the following warning generated by removing a
dpmac that is not up.
[ 40.942937] called from state READY
[ 40.946442] WARNING: CPU: 0 PID: 755 at drivers/net/phy/phy.c:838
phy_stop+0x6c/0x78
[ 40.954171] Modules linked in:
[ 40.957214] CPU: 0 PID: 755 Comm: bash Tainted: G W
5.4.0-03629-gfd7102c32b2c-dirty #911
[ 40.966592] Hardware name: NXP Layerscape LX2160ARDB (DT)
[ 40.971978] pstate: 40000005 (nZcv daif -PAN -UAO)
[ 40.976756] pc : phy_stop+0x6c/0x78
[ 40.980232] lr : phy_stop+0x6c/0x78
(..)
[ 41.066487] Call trace:
[ 41.068922] phy_stop+0x6c/0x78
[ 41.072052] dpaa2_mac_stop.part.4+0x34/0x5c
[ 41.076309] dpaa2_mac_remove+0x9c/0xa8
Also, remove the IFF_UP flag from the mac netdev since the PHY is not
anymore started at probe time but is rather started/stopped on ifconfig
up/down.
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Diffstat (limited to 'arch/arm64/boot/dts/freescale/imx8mn.dtsi')
0 files changed, 0 insertions, 0 deletions