summaryrefslogtreecommitdiff
path: root/arch/arm64/boot/dts
diff options
context:
space:
mode:
authorDaniel Thompson <daniel.thompson@linaro.org>2022-01-27 17:35:54 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-04-15 14:18:07 +0200
commit583fcb66ab17ff576fe95d20629257df939d1599 (patch)
treec9c8da0d25872f4ed2b89beb7de3a53766c8a153 /arch/arm64/boot/dts
parent755dbc3d73789ac9f0017c729abf5e4b153bf799 (diff)
soc: qcom: aoss: remove spurious IRQF_ONESHOT flags
[ Upstream commit 8030cb9a55688c1339edd284d9d6ce5f9fc75160 ] Quoting the header comments, IRQF_ONESHOT is "Used by threaded interrupts which need to keep the irq line disabled until the threaded handler has been run.". When applied to an interrupt that doesn't request a threaded irq then IRQF_ONESHOT has a lesser known (undocumented?) side effect, which it to disable the forced threading of the irq. For "normal" kernels (without forced threading) then, if there is no thread_fn, then IRQF_ONESHOT is a nop. In this case disabling forced threading is not appropriate for this driver because it calls wake_up_all() and this API cannot be called from no-thread interrupt handlers on PREEMPT_RT systems (deadlock risk, triggers sleeping-while-atomic warnings). Fix this by removing IRQF_ONESHOT. Fixes: 2209481409b7 ("soc: qcom: Add AOSS QMP driver") Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org> [bjorn: Added Fixes tag] Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> Link: https://lore.kernel.org/r/20220127173554.158111-1-daniel.thompson@linaro.org Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'arch/arm64/boot/dts')
0 files changed, 0 insertions, 0 deletions