diff options
| author | Xin Xie <xxie@nvidia.com> | 2011-03-17 16:02:13 -0700 |
|---|---|---|
| committer | Varun Colbert <vcolbert@nvidia.com> | 2011-03-22 16:39:24 -0800 |
| commit | 3218d13d46522296c952ce1fe23b95f99dbcaa50 (patch) | |
| tree | 2995ba5c722b7eb6f4a44aabbb7fdc79ddb8d1b0 /arch | |
| parent | fe2156c8af2b43a71138e86ce48e0221f51e0091 (diff) | |
[ARM]: tegra: fix APB DMA transfer timeout
In one bug report, the APB readl DMA transfer took up to 300mS. And
after apb_readl() has the timeout, the kernel crashed due to the NULL
pointer dereference.
In the apb_readl(), after the timeout the tegra_dma_req is destroyed at
the function return. But the DMA interrupt handler later will try to
delete the same destroyed DMA request link list node which will cause
the kernel crash.
Fix this by dequeue the DMA request if the DMA transfer timeout happens.
Reviewed-on: http://git-master/r/23413
(cherry picked from commit 41d4494d0d3235b8f0c605364d5bd0370f3d5323)
Change-Id: Id62b73ea4b81294a85ff1dfcfd96fede07f9497d
Reviewed-on: http://git-master/r/23775
Reviewed-by: Jonathan Mayo <jmayo@nvidia.com>
Reviewed-by: Scott Peterson <speterson@nvidia.com>
Tested-by: Bharat Nihalani <bnihalani@nvidia.com>
Diffstat (limited to 'arch')
| -rw-r--r-- | arch/arm/mach-tegra/apbio.c | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/arch/arm/mach-tegra/apbio.c b/arch/arm/mach-tegra/apbio.c index d6e08c966e72..2d83ae3a51c2 100644 --- a/arch/arm/mach-tegra/apbio.c +++ b/arch/arm/mach-tegra/apbio.c @@ -66,10 +66,12 @@ static inline u32 apb_readl(unsigned long offset) tegra_dma_enqueue_req(tegra_apb_dma, &req); ret = wait_for_completion_timeout(&tegra_apb_wait, - msecs_to_jiffies(50)); + msecs_to_jiffies(400)); - if (WARN(ret == 0, "apb read dma timed out")) + if (WARN(ret == 0, "apb read dma timed out")) { + tegra_dma_dequeue_req(tegra_apb_dma, &req); *(u32 *)tegra_apb_bb = 0; + } mutex_unlock(&tegra_apb_dma_lock); return *((u32 *)tegra_apb_bb); @@ -103,7 +105,10 @@ static inline void apb_writel(u32 value, unsigned long offset) tegra_dma_enqueue_req(tegra_apb_dma, &req); ret = wait_for_completion_timeout(&tegra_apb_wait, - msecs_to_jiffies(50)); + msecs_to_jiffies(400)); + + if (WARN(ret == 0, "apb write dma timed out")) + tegra_dma_dequeue_req(tegra_apb_dma, &req); mutex_unlock(&tegra_apb_dma_lock); } |