summaryrefslogtreecommitdiff
path: root/arch
diff options
context:
space:
mode:
authorYisheng Xie <xieyisheng1@huawei.com>2018-02-28 14:59:22 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-03-24 10:58:40 +0100
commit603879959893f807290ec8c1c08cd21da8fe37bd (patch)
treebcef77f3725e8c49e7516e4ce0d3f66ba124f47d /arch
parent26dc7476efad2151aadb7f72c0c8a253823ef289 (diff)
staging: android: ashmem: Fix possible deadlock in ashmem_ioctl
commit 740a5759bf222332fbb5eda42f89aa25ba38f9b2 upstream. ashmem_mutex may create a chain of dependencies like: CPU0 CPU1 mmap syscall ioctl syscall -> mmap_sem (acquired) -> ashmem_ioctl -> ashmem_mmap -> ashmem_mutex (acquired) -> ashmem_mutex (try to acquire) -> copy_from_user -> mmap_sem (try to acquire) There is a lock odering problem between mmap_sem and ashmem_mutex causing a lockdep splat[1] during a syzcaller test. This patch fixes the problem by move copy_from_user out of ashmem_mutex. [1] https://www.spinics.net/lists/kernel/msg2733200.html Fixes: ce8a3a9e76d0 (staging: android: ashmem: Fix a race condition in pin ioctls) Reported-by: syzbot+d7a918a7a8e1c952bc36@syzkaller.appspotmail.com Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com> Cc: "Joel Fernandes (Google)" <joel.opensrc@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'arch')
0 files changed, 0 insertions, 0 deletions