summaryrefslogtreecommitdiff
path: root/arch
diff options
context:
space:
mode:
authorGwendal Grignou <gwendal@chromium.org>2017-03-03 09:00:09 -0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-10-08 10:26:11 +0200
commit16db9205d3f89911b4d0d92a84049b70213a8927 (patch)
tree290a7c1a8139b41fae8e0d568ff9dc7ee8cee5c8 /arch
parent49c3226c06574bd57d6c4a9aec6641d28fda5b52 (diff)
libata: transport: Remove circular dependency at free time
[ Upstream commit d85fc67dd11e9a32966140677d4d6429ca540b25 ] Without this patch, failed probe would not free resources like irq. ata port tdev object currently hold a reference to the ata port object. Therefore the ata port object release function will not get called until the ata_tport_release is called. But that would never happen, releasing the last reference of ata port dev is done by scsi_host_release, which is called by ata_host_release when the ata port object is released. The ata device objects actually do not need to explicitly hold a reference to their real counterpart, given the transport objects are the children of these objects and device_add() is call for each child. We know the parent will not be deleted until we call the child's device_del(). Reported-by: Matthew Whitehead <tedheadster@gmail.com> Tested-by: Matthew Whitehead <tedheadster@gmail.com> Suggested-by: Tejun Heo <tj@kernel.org> Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Signed-off-by: Tejun Heo <tj@kernel.org> Signed-off-by: Sasha Levin <alexander.levin@verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'arch')
0 files changed, 0 insertions, 0 deletions