diff options
| author | Tejun Heo <htejun@gmail.com> | 2006-01-06 09:49:03 +0100 |
|---|---|---|
| committer | Jens Axboe <axboe@suse.de> | 2006-01-06 09:49:03 +0100 |
| commit | 8ffdc6550c47f75ca4e6c9f30a2a89063e035cf2 (patch) | |
| tree | a478b9acef5c66242a964154f7ad3a0ea750ef0f /drivers/cdrom/cdu31a.c | |
| parent | 64100099ed22f71cce656c5c2caecf5c9cf255dc (diff) | |
[BLOCK] add @uptodate to end_that_request_last() and @error to rq_end_io_fn()
add @uptodate argument to end_that_request_last() and @error
to rq_end_io_fn(). there's no generic way to pass error code
to request completion function, making generic error handling
of non-fs request difficult (rq->errors is driver-specific and
each driver uses it differently). this patch adds @uptodate
to end_that_request_last() and @error to rq_end_io_fn().
for fs requests, this doesn't really matter, so just using the
same uptodate argument used in the last call to
end_that_request_first() should suffice. imho, this can also
help the generic command-carrying request jens is working on.
Signed-off-by: tejun heo <htejun@gmail.com>
Signed-Off-By: Jens Axboe <axboe@suse.de>
Diffstat (limited to 'drivers/cdrom/cdu31a.c')
| -rw-r--r-- | drivers/cdrom/cdu31a.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/cdrom/cdu31a.c b/drivers/cdrom/cdu31a.c index ac96de15d833..378e88d20757 100644 --- a/drivers/cdrom/cdu31a.c +++ b/drivers/cdrom/cdu31a.c @@ -1402,7 +1402,7 @@ static void do_cdu31a_request(request_queue_t * q) if (!end_that_request_first(req, 1, nblock)) { spin_lock_irq(q->queue_lock); blkdev_dequeue_request(req); - end_that_request_last(req); + end_that_request_last(req, 1); spin_unlock_irq(q->queue_lock); } continue; |