diff options
| author | Johannes Berg <johannes@sipsolutions.net> | 2008-06-18 09:29:37 +0200 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2008-06-20 15:45:29 +0200 |
| commit | 0f476b6d91a1395bda6464e653ce66ea9bea7167 (patch) | |
| tree | 28a7f73ebc553dec0ee136395c99f641b0cbf6cc /drivers/char/agp/sworks-agp.c | |
| parent | 4620b49f76096fa5183eecad7d689faa898a4c82 (diff) | |
softirq: remove irqs_disabled warning from local_bh_enable
There's no need to use local_irq_save() over local_irq_disable() in the
local_bh_enable code since it is a bug to call it with irqs disabled and
do_softirq will enable irqs if there is any pending work.
Consolidate the code from local_bh_enable and ..._ip to avoid having a
disconnect between them in the warnings they trigger that is currently
there.
Also always trigger the warning on in_irq(), not just in the
trace-irqflags case.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Cc: Michael Buesch <mb@bu3sch.de>
Cc: David Ellingsworth <david@identd.dyndns.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'drivers/char/agp/sworks-agp.c')
0 files changed, 0 insertions, 0 deletions