summaryrefslogtreecommitdiff
path: root/drivers/char/bfin-otp.c
diff options
context:
space:
mode:
authorTrond Myklebust <Trond.Myklebust@netapp.com>2013-08-28 13:35:13 -0400
committerBen Hutchings <ben@decadent.org.uk>2013-09-10 01:57:35 +0100
commit18520e30c350ad3a36a9e4e0f0b0eafb3b260332 (patch)
tree59111b9adc7f4948bed142da77a1f5ceea6c2200 /drivers/char/bfin-otp.c
parent16a68fe90cc49cd20acfa9604a35827593ce4fc3 (diff)
SUNRPC: Fix memory corruption issue on 32-bit highmem systems
commit 347e2233b7667e336d9f671f1a52dfa3f0416e2c upstream. Some architectures, such as ARM-32 do not return the same base address when you call kmap_atomic() twice on the same page. This causes problems for the memmove() call in the XDR helper routine "_shift_data_right_pages()", since it defeats the detection of overlapping memory ranges, and has been seen to corrupt memory. The fix is to distinguish between the case where we're doing an inter-page copy or not. In the former case of we know that the memory ranges cannot possibly overlap, so we can additionally micro-optimise by replacing memmove() with memcpy(). Reported-by: Mark Young <MYoung@nvidia.com> Reported-by: Matt Craighead <mcraighead@nvidia.com> Cc: Bruce Fields <bfields@fieldses.org> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> Tested-by: Matt Craighead <mcraighead@nvidia.com> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'drivers/char/bfin-otp.c')
0 files changed, 0 insertions, 0 deletions