summaryrefslogtreecommitdiff
path: root/drivers/char/snsc.h
diff options
context:
space:
mode:
authorBodo Stroesser <bstroesser@ts.fujitsu.com>2014-04-14 09:46:51 -0500
committerLinus Torvalds <torvalds@linux-foundation.org>2014-04-17 12:23:06 -0700
commit48e8ac2979920ffa39117e2d725afa3a749bfe8d (patch)
tree44f330918528924f664a69231d1de8f813f77cad /drivers/char/snsc.h
parenta94cdd1f4d30f12904ab528152731fb13a812a16 (diff)
ipmi: Fix a race restarting the timer
With recent changes it is possible for the timer handler to detect an idle interface and not start the timer, but the thread to start an operation at the same time. The thread will not start the timer in that instance, resulting in the timer not running. Instead, move all timer operations under the lock and start the timer in the thread if it detect non-idle and the timer is not already running. Moving under locks allows the last timeout to be set in both the thread and the timer. 'Timer is not running' means that the timer is not pending and smi_timeout() is not running. So we need a flag to detect this correctly. Also fix a few other timeout bugs: setting the last timeout when the interrupt has to be disabled and the timer started, and setting the last timeout in check_start_timer_thread possibly racing with the timer Signed-off-by: Corey Minyard <cminyard@mvista.com> Signed-off-by: Bodo Stroesser <bstroesser@ts.fujitsu.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/char/snsc.h')
0 files changed, 0 insertions, 0 deletions