summaryrefslogtreecommitdiff
path: root/drivers/char
diff options
context:
space:
mode:
authorKees Cook <keescook@chromium.org>2014-06-10 10:51:08 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-07-09 16:59:15 -0700
commit4171ee9e3cd27718ce21f19aa00ea892655b28af (patch)
tree81d71272aa2b57141f0f0fc4649c9e80b859683f /drivers/char
parent7b88344631536cdc258b83c7a67f9117dd05e208 (diff)
bsr: avoid format string leaking into device name
This makes sure a format string cannot accidentally leak into a device name. Signed-off-by: Kees Cook <keescook@chromium.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/char')
-rw-r--r--drivers/char/bsr.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/char/bsr.c b/drivers/char/bsr.c
index 8fedbc250414..a6cef548e01e 100644
--- a/drivers/char/bsr.c
+++ b/drivers/char/bsr.c
@@ -259,7 +259,7 @@ static int bsr_add_node(struct device_node *bn)
}
cur->bsr_device = device_create(bsr_class, NULL, cur->bsr_dev,
- cur, cur->bsr_name);
+ cur, "%s", cur->bsr_name);
if (IS_ERR(cur->bsr_device)) {
printk(KERN_ERR "device_create failed for %s\n",
cur->bsr_name);