diff options
| author | Anson Huang <Anson.Huang@nxp.com> | 2018-11-03 10:44:49 +0800 |
|---|---|---|
| committer | Jason Liu <jason.hui.liu@nxp.com> | 2019-02-12 10:35:02 +0800 |
| commit | fd67888f2f6356c5f0657e112413e5cfc51590f7 (patch) | |
| tree | 1947d3a7d5ef26666eab204ee9d9e1ab6ac97abc /drivers/clocksource | |
| parent | fdb630b4228a7f0bb2bdd95485a3f41563f20718 (diff) | |
MLK-20202 clocksource: imx-gpt: fix coverity issues
This patch fixes coverity issues as below:
1. resource leak
2. possible case of division by zero.
Fix #1 by kfree the resource before return error;
Fix #2 by adding zero check before registering delay timer.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Bai Ping <ping.bai@nxp.com>
Diffstat (limited to 'drivers/clocksource')
| -rw-r--r-- | drivers/clocksource/timer-imx-gpt.c | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/drivers/clocksource/timer-imx-gpt.c b/drivers/clocksource/timer-imx-gpt.c index 9d7dd093bf64..85ef1674d62f 100644 --- a/drivers/clocksource/timer-imx-gpt.c +++ b/drivers/clocksource/timer-imx-gpt.c @@ -171,6 +171,9 @@ static int __init mxc_clocksource_init(struct imx_timer *imxtm) unsigned int c = clk_get_rate(imxtm->clk_per); void __iomem *reg = imxtm->base + imxtm->gpt->reg_tcn; + if (c == 0) + return -EINVAL; + #ifndef CONFIG_ARM64 imx_delay_timer.read_current_timer = &imx_read_current_timer; imx_delay_timer.freq = c; @@ -493,12 +496,16 @@ static int __init mxc_timer_init_dt(struct device_node *np, enum imx_gpt_type t return -ENOMEM; imxtm->base = of_iomap(np, 0); - if (!imxtm->base) + if (!imxtm->base) { + kfree(imxtm); return -ENXIO; + } imxtm->irq = irq_of_parse_and_map(np, 0); - if (imxtm->irq <= 0) + if (imxtm->irq <= 0) { + kfree(imxtm); return -EINVAL; + } imxtm->clk_ipg = of_clk_get_by_name(np, "ipg"); |