diff options
author | Tony Luck <tony.luck@intel.com> | 2016-04-28 15:40:00 -0700 |
---|---|---|
committer | Borislav Petkov <bp@suse.de> | 2016-05-02 19:44:43 +0200 |
commit | 2c1ea4c700af3dcfc8eabd94c91d1830b42c5461 (patch) | |
tree | 1936dbdab9f678c1c9b1e9cc4524755df588a4de /drivers/edac/amd64_edac.h | |
parent | 5359534505c74841dbb2c6baf41db1a395acd34d (diff) |
EDAC, sb_edac: Use cpu family/model in driver detection
Instead of picking a random PCI ID from the dozen or so we need to
access, just use x86_match_cpu() to pick based on CPU model number. The
choosing of PCI devices has been problematic in the past, see
11249e739929 ("sb_edac: Fix detection on SNB machines")
which fixed problems introduced by
d0585cd815fa ("sb_edac: Claim a different PCI device").
This is especially ugly if future hardware might not even have
EDAC-relevant registers in PCI config space and we would still be
required to choose some "random" PCI devices to scan for just so our
driver loads.
Is this cleaner/clearer? It deletes much more code than it adds. Only
tested on Broadwell. The driver loads/unloads and loads again. Still
decodes errors too.
Signed-off-by: Tony Luck <tony.luck@intel.com>
Suggested-by: Borislav Petkov <bp@alien8.de>
Signed-off-by: Borislav Petkov <bp@suse.de>
Diffstat (limited to 'drivers/edac/amd64_edac.h')
0 files changed, 0 insertions, 0 deletions