diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2017-02-08 02:46:01 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-03-15 09:57:15 +0800 |
| commit | bb5b96344ed378a1d5b8cf3bd149bb86919f3b9f (patch) | |
| tree | f7cacd31eed3cda72be356e8fcb7bc898b6e85e2 /drivers/gpu/drm/drm_encoder_slave.c | |
| parent | 59fc34fc69066bfabf8bed21f4ce5bf312e68bb3 (diff) | |
drm/atomic: fix an error code in mode_fixup()
commit f9ad86e42d0303eeb8e0d41bb208153022ebd9d2 upstream.
Having "ret" be a bool type works for everything except
ret = funcs->atomic_check(). The other functions all return zero on
error but ->atomic_check() returns negative error codes. We want to
propagate the error code but instead we return 1.
I found this bug with static analysis and I don't know if it affects
run time.
Fixes: 4cd4df8080a3 ("drm/atomic: Add ->atomic_check() to encoder helpers")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20170207234601.GA23981@mwanda
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/gpu/drm/drm_encoder_slave.c')
0 files changed, 0 insertions, 0 deletions