diff options
author | J. Bruce Fields <bfields@redhat.com> | 2014-04-09 11:07:01 -0400 |
---|---|---|
committer | J. Bruce Fields <bfields@redhat.com> | 2014-04-18 14:46:45 +0200 |
commit | fc208d026be0c7d60db9118583fc62f6ca97743d (patch) | |
tree | f83136cbad74acd9272b9cffb9c62efc96193119 /drivers/hid/hid-ids.h | |
parent | 3758cf7e14b753838fe754ede3862af10b35fdac (diff) |
Revert "nfsd4: fix nfs4err_resource in 4.1 case"
Since we're still limiting attributes to a page, the result here is that
a large getattr result will return NFS4ERR_REP_TOO_BIG/TOO_BIG_TO_CACHE
instead of NFS4ERR_RESOURCE.
Both error returns are wrong, and the real bug here is the arbitrary
limit on getattr results, fixed by as-yet out-of-tree patches. But at a
minimum we can make life easier for clients by sticking to one broken
behavior in released kernels instead of two....
Trond says:
one immediate consequence of this patch will be that NFSv4.1
clients will now report EIO instead of EREMOTEIO if they hit the
problem. That may make debugging a little less obvious.
Another consequence will be that if we ever do try to add client
side handling of NFS4ERR_REP_TOO_BIG, then we now have to deal
with the “handle existing buggy server” syndrome.
Reported-by: Trond Myklebust <trond.myklebust@primarydata.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'drivers/hid/hid-ids.h')
0 files changed, 0 insertions, 0 deletions