diff options
author | Jiri Kosina <jkosina@suse.cz> | 2014-08-21 09:57:17 -0500 |
---|---|---|
committer | Jiri Slaby <jslaby@suse.cz> | 2014-09-03 10:54:39 +0200 |
commit | 2ae8a66674a4cd7f2cfee757ee29cb63dce755fe (patch) | |
tree | 52e42aace508740ea154e8d0560028256a9015d0 /drivers/hid/hid-ortek.c | |
parent | 5d1ab637d00b258f7852c963771ed4f1fd0b2de3 (diff) |
HID: logitech: perform bounds checking on device_id early enough
commit ad3e14d7c5268c2e24477c6ef54bbdf88add5d36 upstream.
device_index is a char type and the size of paired_dj_deivces is 7
elements, therefore proper bounds checking has to be applied to
device_index before it is used.
We are currently performing the bounds checking in
logi_dj_recv_add_djhid_device(), which is too late, as malicious device
could send REPORT_TYPE_NOTIF_DEVICE_UNPAIRED early enough and trigger the
problem in one of the report forwarding functions called from
logi_dj_raw_event().
Fix this by performing the check at the earliest possible ocasion in
logi_dj_raw_event().
Reported-by: Ben Hawkes <hawkes@google.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Diffstat (limited to 'drivers/hid/hid-ortek.c')
0 files changed, 0 insertions, 0 deletions