diff options
author | Mathieu Poirier <mathieu.poirier@linaro.org> | 2015-12-17 08:47:02 -0700 |
---|---|---|
committer | Sasha Levin <sasha.levin@oracle.com> | 2016-02-01 12:22:21 -0500 |
commit | dc25a0a0d2bc9296d0d66cbe7a17f698122d3c41 (patch) | |
tree | 308b10fc3e3cc2f4ca47a86e33c2e2585379daad /drivers/hwtracing | |
parent | 5de8e1eed3221cb8737c2617c4567b70833795e6 (diff) |
coresight: checking for NULL string in coresight_name_match()
[ Upstream commit fadf3a44e974b030e7145218ad1ab25e3ef91738 ]
Connection child names associated to ports can sometimes be NULL,
which is the case when booting a system on QEMU or when the Coresight
power domain isn't switched on.
This patch is adding a check to make sure a NULL string isn't fed
to strcmp(), something that avoid crashing the system.
Cc: <stable@vger.kernel.org> # v3.18+
Reported-by: Tyler Baker <tyler.baker@linaro.org>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Diffstat (limited to 'drivers/hwtracing')
-rw-r--r-- | drivers/hwtracing/coresight/coresight.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c index 894531d315b8..046144fc5aff 100644 --- a/drivers/hwtracing/coresight/coresight.c +++ b/drivers/hwtracing/coresight/coresight.c @@ -543,7 +543,7 @@ static int coresight_name_match(struct device *dev, void *data) to_match = data; i_csdev = to_coresight_device(dev); - if (!strcmp(to_match, dev_name(&i_csdev->dev))) + if (to_match && !strcmp(to_match, dev_name(&i_csdev->dev))) return 1; return 0; |