diff options
| author | Namhyung Kim <namhyung@gmail.com> | 2011-07-18 17:38:43 +1000 |
|---|---|---|
| committer | NeilBrown <neilb@suse.de> | 2011-07-18 17:38:43 +1000 |
| commit | 2c4193df379bb89114ff60d4b0fa66131abe6a75 (patch) | |
| tree | 5eed0d76e3b8ae12a543e0deab771c48f6597a40 /drivers/md/raid10.c | |
| parent | 1765a367a3b5d5e9692949b0c5ec933eff2c0701 (diff) | |
md/raid10: get rid of duplicated conditional expression
Variable 'first' is initialized to zero and updated to @rdev->raid_disk
only if it is greater than 0. Thus condition '>= first' always implies
'>= 0' so the latter is not needed.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Diffstat (limited to 'drivers/md/raid10.c')
| -rw-r--r-- | drivers/md/raid10.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index 6e846688962f..d55ae12b2d8c 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c @@ -1093,8 +1093,7 @@ static int raid10_add_disk(mddev_t *mddev, mdk_rdev_t *rdev) if (rdev->raid_disk >= 0) first = last = rdev->raid_disk; - if (rdev->saved_raid_disk >= 0 && - rdev->saved_raid_disk >= first && + if (rdev->saved_raid_disk >= first && conf->mirrors[rdev->saved_raid_disk].rdev == NULL) mirror = rdev->saved_raid_disk; else |