diff options
| author | Neil Brown <neilb@notabene.brown> | 2008-06-28 08:31:26 +1000 |
|---|---|---|
| committer | Neil Brown <neilb@notabene.brown> | 2008-06-28 08:31:26 +1000 |
| commit | f48ed538386cb41559282d989354e8f5d442d71c (patch) | |
| tree | 3faa24718c098f19b7e331eae0ba29f145e902da /drivers/md | |
| parent | 5e96ee65c8bd629ce093da67a066d3946468298a (diff) | |
Close race in md_probe
There is a possible race in md_probe. If two threads call md_probe
for the same device, then one could exit (having checked that
->gendisk exists) before the other has called kobject_init_and_add,
thus returning an incomplete kobj which will cause problems when
we try to add children to it.
So extend the range of protection of disks_mutex slightly to
avoid this possibility.
Signed-off-by: Neil Brown <neilb@suse.de>
Diffstat (limited to 'drivers/md')
| -rw-r--r-- | drivers/md/md.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/md.c b/drivers/md/md.c index 261322722c19..97852099defd 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -3359,9 +3359,9 @@ static struct kobject *md_probe(dev_t dev, int *part, void *data) disk->queue = mddev->queue; add_disk(disk); mddev->gendisk = disk; - mutex_unlock(&disks_mutex); error = kobject_init_and_add(&mddev->kobj, &md_ktype, &disk->dev.kobj, "%s", "md"); + mutex_unlock(&disks_mutex); if (error) printk(KERN_WARNING "md: cannot register %s/md - name in use\n", disk->disk_name); |