diff options
| author | Mauro Carvalho Chehab <mchehab@redhat.com> | 2013-04-01 11:46:52 -0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2013-04-04 14:35:40 -0300 |
| commit | 53faa685fa7df0e12751eebbda30bc7e7bb5e71a (patch) | |
| tree | c0d055dccdebeef8b5b1841a892b4758f5f7cffe /drivers/media/common | |
| parent | f9f11dfe4831adb1531e1face9dcd9fc57665d2e (diff) | |
[media] siano: Fix array boundary at smscore_translate_msg()
As reported by Dan Carpenter:
FYI, there are new smatch warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next master
head: da17d7bda957ae4697b6abc0793f74fb9b50b58f
commit: 4c3bdb5e2f5612ceb99ac17dbbe673b59a94d105 [media] siano: better debug send/receive messages
drivers/media/common/siano/smscoreapi.c:396 smscore_translate_msg() error: buffer overflow 'siano_msgs' 401 <= 401
While it is almost impossible for this error to happen in
practice, as it would require the siano's firmware to return
an special invalid answer to a message request, fixing it
is trivial. So, let's do it.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/common')
| -rw-r--r-- | drivers/media/common/siano/smscoreapi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/common/siano/smscoreapi.c b/drivers/media/common/siano/smscoreapi.c index ebb9eceb1dca..45ac9eea4882 100644 --- a/drivers/media/common/siano/smscoreapi.c +++ b/drivers/media/common/siano/smscoreapi.c @@ -389,7 +389,7 @@ char *smscore_translate_msg(enum msg_types msgtype) int i = msgtype - MSG_TYPE_BASE_VAL; char *msg; - if (i < 0 || i > ARRAY_SIZE(siano_msgs)) + if (i < 0 || i >= ARRAY_SIZE(siano_msgs)) return "Unknown msg type"; msg = siano_msgs[i]; |