summaryrefslogtreecommitdiff
path: root/drivers/media/radio/wl128x
diff options
context:
space:
mode:
authorPaul Cassella <fortytwo-ivtv@manetheren.bigw.org>2011-02-12 10:39:51 -0300
committerMauro Carvalho Chehab <mchehab@redhat.com>2011-03-21 20:32:35 -0300
commit7fd4b41f053681cccf188cc1731ae43fe38fa969 (patch)
treeca2e84f40e2483357882570b1fb82d17143830ef /drivers/media/radio/wl128x
parent0d44b1235c60bf3134f5730ebb4a115f857a2da4 (diff)
[media] ivtv: yuv: handle get_user_pages() -errno returns
get_user_pages() may return -errno, such as -EFAULT. So don't blindly use its return value as an offset into dma->map[] for the next get_user_pages() call. Since we'll give up and return an error if either fails, don't even make the second call if the first failed to give us exactly what we were looking for. The old code would also call put_page() on as many elements of dma->map[] as we'd asked for, regardless of how many were valid. [Andy Walls modified this patch to return -EFAULT instead of -EINVAL as Paul's observation "I'm not sure -EINVAL is the best return code vs -EFAULT or -ENOMEM, [...]" was correct. The return value bubbles up as a return code for write(), for which the V4L2 API spec indicates EINVAL is incorrect and EFAULT is correct.] Signed-off-by: Paul Cassella <fortytwo-ivtv@maneteren.bigw.org> Signed-off-by: Andy Walls <awalls@md.metrocast.net> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/radio/wl128x')
0 files changed, 0 insertions, 0 deletions