diff options
| author | Zhang Rui <rui.zhang@intel.com> | 2008-09-11 10:56:00 +0800 |
|---|---|---|
| committer | Len Brown <len.brown@intel.com> | 2008-11-03 22:56:32 -0500 |
| commit | c2d06fe338912ee56c2ddd7de5574d5396ed8050 (patch) | |
| tree | 6a7e6ad344135d6dca8c0d7984034995784fe233 /drivers/misc | |
| parent | 2830c9fb8e66cee70b8bffdfb0de01c144c7e643 (diff) | |
intel_menlow: don't set max_state a negative value
max_state is unsigned long.
don't set max_state a negative value
Cc : Thomas Sujith <sujith.thomas@intel.com>
Cc : Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
Diffstat (limited to 'drivers/misc')
| -rw-r--r-- | drivers/misc/intel_menlow.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/misc/intel_menlow.c b/drivers/misc/intel_menlow.c index e00a2756e97e..124b37ddb5c1 100644 --- a/drivers/misc/intel_menlow.c +++ b/drivers/misc/intel_menlow.c @@ -71,6 +71,9 @@ static int memory_get_int_max_bandwidth(struct thermal_cooling_device *cdev, if (ACPI_FAILURE(status)) return -EFAULT; + if (!value) + return -EINVAL; + *max_state = value - 1; return 0; } @@ -121,7 +124,7 @@ static int memory_set_cur_bandwidth(struct thermal_cooling_device *cdev, if (memory_get_int_max_bandwidth(cdev, &max_state)) return -EFAULT; - if (max_state < 0 || state > max_state) + if (state > max_state) return -EINVAL; arg_list.count = 1; |