diff options
| author | Nicolas Dichtel <nicolas.dichtel@6wind.com> | 2016-06-13 10:31:07 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-05-10 10:26:29 +0200 |
| commit | 959c8d63b47eceacf3890450b1cad44f22e6a139 (patch) | |
| tree | fe2d9b65a2dd8ea10780bdf69ab7dee6f854b7b7 /drivers/net/geneve.c | |
| parent | b7ad8f035e6703622a91e70d5682589346295a68 (diff) | |
ovs/geneve: fix rtnl notifications on iface deletion
commit 41009481b690493c169ce85f591b9d32c6fd9422 upstream.
The function geneve_dev_create_fb() (only used by ovs) never calls
rtnl_configure_link(). The consequence is that dev->rtnl_link_state is
never set to RTNL_LINK_INITIALIZED.
During the deletion phase, the function rollback_registered_many() sends
a RTM_DELLINK only if dev->rtnl_link_state is set to RTNL_LINK_INITIALIZED.
Fixes: e305ac6cf5a1 ("geneve: Add support to collect tunnel metadata.")
CC: Pravin B Shelar <pshelar@nicira.com>
CC: Jesse Gross <jesse@nicira.com>
CC: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/net/geneve.c')
| -rw-r--r-- | drivers/net/geneve.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index ec6218ab8137..1988bc00de3c 100644 --- a/drivers/net/geneve.c +++ b/drivers/net/geneve.c @@ -1363,6 +1363,10 @@ struct net_device *geneve_dev_create_fb(struct net *net, const char *name, if (err) goto err; + err = rtnl_configure_link(dev, NULL); + if (err < 0) + goto err; + return dev; err: |