diff options
author | Thomas Gleixner <tglx@linutronix.de> | 2007-04-13 20:45:17 +0200 |
---|---|---|
committer | Adrian Bunk <bunk@stusta.de> | 2007-04-13 22:58:22 +0200 |
commit | 0243ef462fbe940dafde1f47d3ea29dbf5146b21 (patch) | |
tree | 44cf4ad4bf8680f325c1c1f096d49f45aff962d3 /drivers/net/skge.c | |
parent | 1ee709383b60148263f139af790c8b5a22c2e586 (diff) |
i386: fix file_read_actor() and pipe_read() for original i386 systems
The __copy_to_user_inatomic() calls in file_read_actor() and pipe_read()
are broken on original i386 machines, where WP-works-ok == false, as
__copy_to_user_inatomic() on such systems calls functions which might
sleep and/or contain cond_resched() calls inside of a kmap_atomic()
region.
The original check for WP-works-ok was in access_ok(), but got moved
during the 2.5 series to fix a race vs. swap.
Return the number of bytes to copy in the case where we are in an atomic
region, so the non atomic code pathes in file_read_actor() and
pipe_read() are taken.
This could be optimized to avoid the kmap_atomicby moving the check for
WP-works-ok into fault_in_pages_writeable(), but this is more intrusive
and can be done later.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Diffstat (limited to 'drivers/net/skge.c')
0 files changed, 0 insertions, 0 deletions