summaryrefslogtreecommitdiff
path: root/drivers/net/wireless/broadcom
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2018-06-05 14:31:39 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-10-03 17:00:52 -0700
commit62bd8064fa8820d4fc5dc3c504e25522f9f18f90 (patch)
tree4880c6652fd12de4cdfa925b7d138bfcb4f3a041 /drivers/net/wireless/broadcom
parent3c7f6b2cf6d696baf651125ba6a208fb755882b6 (diff)
rndis_wlan: potential buffer overflow in rndis_wlan_auth_indication()
[ Upstream commit ae636fb1554833ee5133ca47bf4b2791b6739c52 ] This is a static checker fix, not something I have tested. The issue is that on the second iteration through the loop, we jump forward by le32_to_cpu(auth_req->length) bytes. The problem is that if the length is more than "buflen" then we end up with a negative "buflen". A negative buflen is type promoted to a high positive value and the loop continues but it's accessing beyond the end of the buffer. I believe the "auth_req->length" comes from the firmware and if the firmware is malicious or buggy, you're already toasted so the impact of this bug is probably not very severe. Fixes: 030645aceb3d ("rndis_wlan: handle 802.11 indications from device") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/net/wireless/broadcom')
0 files changed, 0 insertions, 0 deletions