diff options
author | Tony Lindgren <tony@atomide.com> | 2014-08-24 17:44:22 +0530 |
---|---|---|
committer | Kishon Vijay Abraham I <kishon@ti.com> | 2014-08-24 17:47:54 +0530 |
commit | 85601b8d81e24ce9ae2d31e93f35468ab7616b18 (patch) | |
tree | 7e80131fa23c9bd0077da659af6a1e145d6ab2c6 /drivers/phy/phy-exynos5-usbdrd.c | |
parent | 96be39ab34b77c6f6f5cd6ae03aac6c6449ee5c4 (diff) |
usb: phy: twl4030-usb: Fix lost interrupts after ID pin goes down
Commit 249751f22380 ("usb: phy: twl4030-usb: poll for ID disconnect")
added twl4030_id_workaround_work() to deal with lost interrupts
after ID pin goes down. Looks like commit f1ddc24c9e33 ("usb: phy:
twl4030-usb: remove *set_suspend* and *phy_init* ops") changed
things around for the generic phy framework, and delayed work no
longer got called except initially during boot.
The PHY connect and disconnect interrupts for twl4030-usb are not
working after disconnecting a USB-A cable from the board, and the
deeper idle states for omap are blocked as the USB controller
stays busy.
The issue can be solved by calling delayed work from twl4030_usb_irq()
when ID pin is down and the PHY is not asleep like we already do
in twl4030_id_workaround_work().
But as both twl4030_usb_irq() and twl4030_id_workaround_work()
already do pretty much the same thing, let's call twl4030_usb_irq()
from twl4030_id_workaround_work() instead of adding some more
duplicate code. We also must call sysfs_notify() only when we have
an interrupt and not from the delayed work as notified by
Grazvydas Ignotas <notasas@gmail.com>.
Fixes: f1ddc24c9e33 ("usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops")
Cc: stable@vger.kernel.org # v3.13+
Acked-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Diffstat (limited to 'drivers/phy/phy-exynos5-usbdrd.c')
0 files changed, 0 insertions, 0 deletions