summaryrefslogtreecommitdiff
path: root/drivers/pinctrl/pinctrl-rk805.c
diff options
context:
space:
mode:
authorMarco Felsch <m.felsch@pengutronix.de>2018-10-02 10:06:46 +0200
committerLinus Walleij <linus.walleij@linaro.org>2018-10-10 14:36:35 +0200
commitf259f896f2348f0302f6f88d4382378cf9d23a7e (patch)
treeecea64683b1e6d765739ddbec161c810cd8dd641 /drivers/pinctrl/pinctrl-rk805.c
parent0238df646e6224016a45505d2c111a24669ebe21 (diff)
pinctrl: mcp23s08: fix irq and irqchip setup order
Since 'commit 02e389e63e35 ("pinctrl: mcp23s08: fix irq setup order")' the irq request isn't the last devm_* allocation. Without a deeper look at the irq and testing this isn't a good solution. Since this driver relies on the devm mechanism, requesting a interrupt should be the last thing to avoid memory corruptions during unbinding. 'Commit 02e389e63e35 ("pinctrl: mcp23s08: fix irq setup order")' fixed the order for the interrupt-controller use case only. The mcp23s08_irq_setup() must be split into two to fix it for the interrupt-controller use case and to register the irq at last. So the irq will be freed first during unbind. Cc: stable@vger.kernel.org Cc: Jan Kundrát <jan.kundrat@cesnet.cz> Cc: Dmitry Mastykin <mastichi@gmail.com> Cc: Sebastian Reichel <sebastian.reichel@collabora.co.uk> Fixes: 82039d244f87 ("pinctrl: mcp23s08: add pinconf support") Fixes: 02e389e63e35 ("pinctrl: mcp23s08: fix irq setup order") Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> Tested-by: Phil Reid <preid@electromag.com.au> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/pinctrl-rk805.c')
0 files changed, 0 insertions, 0 deletions