diff options
| author | Richard Zhao <richard.zhao@freescale.com> | 2011-08-08 09:16:27 +0800 |
|---|---|---|
| committer | Nitin Garg <nitin.garg@freescale.com> | 2014-06-03 21:43:45 -0500 |
| commit | 931819949dcd1f422238996f24fa252675e349de (patch) | |
| tree | 5a37ade3b4541a0dbe7c3b7dcea6841d3b7c4de5 /drivers/rtc | |
| parent | 63787a531d800153196b274a333beb7342430e4d (diff) | |
ENGR00154429 rtc-snvs: request_irq too early
request_irq should be after hw init. It can avoid meaningless interrupt.
Signed-off-by: Richard Zhao <richard.zhao@freescale.com>
Diffstat (limited to 'drivers/rtc')
| -rw-r--r-- | drivers/rtc/rtc-snvs.c | 23 |
1 files changed, 11 insertions, 12 deletions
diff --git a/drivers/rtc/rtc-snvs.c b/drivers/rtc/rtc-snvs.c index 3125ec09926c..dfd784936b28 100644 --- a/drivers/rtc/rtc-snvs.c +++ b/drivers/rtc/rtc-snvs.c @@ -482,19 +482,7 @@ static int snvs_rtc_probe(struct platform_device *pdev) pdata->baseaddr = res->start; pdata->ioaddr = ioremap(pdata->baseaddr, 0xC00); ioaddr = pdata->ioaddr; - - /* Configure and enable the RTC */ pdata->irq = platform_get_irq(pdev, 0); - if (pdata->irq >= 0) { - if (request_irq(pdata->irq, snvs_rtc_interrupt, IRQF_SHARED, - pdev->name, pdev) < 0) { - dev_warn(&pdev->dev, "interrupt not available.\n"); - pdata->irq = -1; - } else { - disable_irq(pdata->irq); - pdata->irq_enable = false; - } - } /* initialize glitch detect */ __raw_writel(SNVS_LPPGDR_INIT, ioaddr + SNVS_LPPGDR); @@ -513,6 +501,17 @@ static int snvs_rtc_probe(struct platform_device *pdev) __raw_writel(0xFFFFFFFF, ioaddr + SNVS_LPSR); udelay(100); + if (pdata->irq >= 0) { + if (request_irq(pdata->irq, snvs_rtc_interrupt, IRQF_SHARED, + pdev->name, pdev) < 0) { + dev_warn(&pdev->dev, "interrupt not available.\n"); + pdata->irq = -1; + } else { + disable_irq(pdata->irq); + pdata->irq_enable = false; + } + } + rtc = rtc_device_register(pdev->name, &pdev->dev, &snvs_rtc_ops, THIS_MODULE); if (IS_ERR(rtc)) { |