diff options
| author | Lalit Chandivade <lalit.chandivade@qlogic.com> | 2011-10-07 16:55:41 -0700 |
|---|---|---|
| committer | James Bottomley <JBottomley@Parallels.com> | 2011-10-16 11:08:16 -0500 |
| commit | 0854f665a1cbb4566d3ebe449169b0200b8cdad0 (patch) | |
| tree | 7e2e771996dd34e0f359b4471d9cf53382802721 /drivers/scsi | |
| parent | aecc3130da7d3a02439bcba428e9fe470ec11f6f (diff) | |
[SCSI] qla4xxx: Fix bidirectional CHAP.
Driver was not setting the bidirectional CHAP bit correctly in
the DDB entry.
JIRA Key: UPSISCSI-108
Signed-off-by: Lalit Chandivade <lalit.chandivade@qlogic.com>
Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi')
| -rw-r--r-- | drivers/scsi/qla4xxx/ql4_def.h | 2 | ||||
| -rw-r--r-- | drivers/scsi/qla4xxx/ql4_mbx.c | 7 |
2 files changed, 6 insertions, 3 deletions
diff --git a/drivers/scsi/qla4xxx/ql4_def.h b/drivers/scsi/qla4xxx/ql4_def.h index d2f7cd64d066..a80adfc6d780 100644 --- a/drivers/scsi/qla4xxx/ql4_def.h +++ b/drivers/scsi/qla4xxx/ql4_def.h @@ -351,6 +351,8 @@ struct ipaddress_config { #define QL4_CHAP_MAX_NAME_LEN 256 #define QL4_CHAP_MAX_SECRET_LEN 100 +#define LOCAL_CHAP 0 +#define BIDI_CHAP 1 struct ql4_chap_format { u8 intr_chap_name[QL4_CHAP_MAX_NAME_LEN]; diff --git a/drivers/scsi/qla4xxx/ql4_mbx.c b/drivers/scsi/qla4xxx/ql4_mbx.c index de733a777803..b60b90301a8b 100644 --- a/drivers/scsi/qla4xxx/ql4_mbx.c +++ b/drivers/scsi/qla4xxx/ql4_mbx.c @@ -872,7 +872,6 @@ void qla4xxx_get_conn_event_log(struct scsi_qla_host * ha) uint32_t max_event_log_entries; uint8_t i; - memset(&mbox_cmd, 0, sizeof(mbox_cmd)); memset(&mbox_sts, 0, sizeof(mbox_cmd)); @@ -1578,7 +1577,8 @@ int qla4xxx_set_param_ddbentry(struct scsi_qla_host *ha, } rval = qla4xxx_set_chap(ha, sess->username, - sess->password, idx, 0); + sess->password, idx, + LOCAL_CHAP); if (rval) goto exit_set_param; @@ -1599,7 +1599,8 @@ int qla4xxx_set_param_ddbentry(struct scsi_qla_host *ha, goto exit_set_param; } rval = qla4xxx_set_chap(ha, sess->username_in, - sess->password_in, idx, 0); + sess->password_in, idx, + BIDI_CHAP); if (rval) goto exit_set_param; } |