diff options
author | Alan Cox <alan@linux.intel.com> | 2010-02-08 10:09:26 +0000 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-03-15 08:49:54 -0700 |
commit | 25262221921cdf3a8c7dbf3ea6a08c816fb8a222 (patch) | |
tree | 0332dd97d7365cf63a84089a035ee66c41a43b4a /drivers/serial/imx.c | |
parent | 4e2f0b48d2a85948cef171961b60ccf994ad24dd (diff) |
tty: Fix the ldisc hangup race
commit 638b9648ab51c9c549ff5735d3de519ef6199df3 upstream.
This was noticed by Matthias Urlichs and he proposed a fix. This patch
does the fixing a different way to avoid introducing several new race
conditions into the code.
The problem case is TTY_DRIVER_RESET_TERMIOS = 0. In that case while we
abort the ldisc change, the hangup processing has not cleaned up and restarted
the ldisc either.
We can't restart the ldisc stuff in the set_ldisc as we don't know what
the hangup did and may touch stuff we shouldn't as we are no longer
supposed to influence the tty at that point in case it has been re-opened
before we get rescheduled.
Instead do it the simple way. Always re-init the ldisc on the hangup, but
use TTY_DRIVER_RESET_TERMIOS to indicate that we should force N_TTY.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/serial/imx.c')
0 files changed, 0 insertions, 0 deletions