diff options
| author | H Hartley Sweeten <hsweeten@visionengravers.com> | 2014-08-25 16:04:33 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-08-30 13:22:33 -0700 |
| commit | e024181b02ed6b833358bede3f2d0c52cb5fb6bc (patch) | |
| tree | d798e1c1b08964aff25d06cb58a494226ad28225 /drivers/staging/comedi/drivers/quatech_daqp_cs.c | |
| parent | 41e7a107104d74d7109a64c80a560f4256db1fdf (diff) | |
staging: comedi: quatech_daqp_cs: fix bug in daqp_ao_insn_write()
The comedi core expects (*insn_write) functions to write insn->n values
to the hardware and return the number of values written.
Currently, this function only writes the first value. Fix it to work
like the core expects.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/comedi/drivers/quatech_daqp_cs.c')
| -rw-r--r-- | drivers/staging/comedi/drivers/quatech_daqp_cs.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c index b1db61d9d834..489f4c8ab862 100644 --- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c +++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c @@ -638,7 +638,6 @@ static int daqp_ao_insn_write(struct comedi_device *dev, { struct daqp_private *devpriv = dev->private; unsigned int chan = CR_CHAN(insn->chanspec); - unsigned int val; int i; if (devpriv->stop) @@ -648,7 +647,8 @@ static int daqp_ao_insn_write(struct comedi_device *dev, outb(0, dev->iobase + DAQP_AUX); for (i = 0; i > insn->n; i++) { - val = data[0]; + unsigned val = data[i]; + val &= 0x0fff; val ^= 0x0800; /* Flip the sign */ val |= (chan << 12); |