diff options
| author | Li Jun <jun.li@nxp.com> | 2018-03-23 13:47:54 +0800 |
|---|---|---|
| committer | Leonard Crestez <leonard.crestez@nxp.com> | 2018-08-24 12:41:33 +0300 |
| commit | a705e8e8b6042f58ad22cb25daa0c70b7d0b22cb (patch) | |
| tree | 62be66411e9325a2418b5d2b5692f19a752875fd /drivers/usb/dwc3 | |
| parent | b72c95137c2608ac00762eeda4fcd04a32ad3d83 (diff) | |
MLK-17887 Revert "usb: dwc3: gadget: skip Set/Clear Halt when invalid"
This reverts commit 3ccf60e1ff5e
("usb: dwc3: gadget: skip Set/Clear Halt when invalid")
"At least macOS seems to be sending
ClearFeature(ENDPOINT_HALT) to endpoints which
aren't Halted. This makes DWC3's CLEARSTALL command
time out which causes several issues for the driver."
but this change is impacting usb CV compliance test with
windows, which using clear EP halt for other purpose in
this case, as this is not resolved on upstream, so revert
this patch for now.
Acke-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Li Jun <jun.li@nxp.com>
Diffstat (limited to 'drivers/usb/dwc3')
| -rw-r--r-- | drivers/usb/dwc3/gadget.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 6e64d3a5f019..188e6343a7d4 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -1373,9 +1373,6 @@ int __dwc3_gadget_ep_set_halt(struct dwc3_ep *dep, int value, int protocol) unsigned transfer_in_flight; unsigned started; - if (dep->flags & DWC3_EP_STALL) - return 0; - if (dep->number > 1) trb = dwc3_ep_prev_trb(dep, dep->trb_enqueue); else @@ -1400,8 +1397,6 @@ int __dwc3_gadget_ep_set_halt(struct dwc3_ep *dep, int value, int protocol) else dep->flags |= DWC3_EP_STALL; } else { - if (!(dep->flags & DWC3_EP_STALL)) - return 0; ret = dwc3_send_clear_stall_ep_cmd(dep); if (ret) |