diff options
| author | Liu Ying <Ying.Liu@freescale.com> | 2015-12-01 14:42:41 +0800 |
|---|---|---|
| committer | Nitin Garg <nitin.garg@nxp.com> | 2016-01-14 11:02:30 -0600 |
| commit | 62e4b33a07eff30a7160be8834ac11e657aa0af4 (patch) | |
| tree | f3b6b1e76459960f7554799333b4634b7c11c834 /drivers/video | |
| parent | 880005d8e6a1bfe9f25100ea9e3939d6f24331ec (diff) | |
MLK-11932 video: fbdev: mxc: ldb: Do not touch fbi->modelist in ldb_init()
We don't have to touch fbi->modelist in ldb_init(), because mxcfb_register()
may initialize the list and add a video mode to the list for us.
This patch fixes the following issue reported by Coverity:
INIT_LIST_HEAD(&fbi->modelist);
Uninitialized scalar variable (UNINIT)
uninit_use_in_call: Using uninitialized value fb_vm. Field fb_vm.name is
uninitialized when calling fb_add_videomode.
fb_add_videomode(&fb_vm, &fbi->modelist);
fb_videomode_to_var(&fbi->var, &fb_vm);
Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
Diffstat (limited to 'drivers/video')
| -rw-r--r-- | drivers/video/fbdev/mxc/ldb.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/video/fbdev/mxc/ldb.c b/drivers/video/fbdev/mxc/ldb.c index e5716cb4b2e3..1d6c9e08590c 100644 --- a/drivers/video/fbdev/mxc/ldb.c +++ b/drivers/video/fbdev/mxc/ldb.c @@ -323,9 +323,6 @@ static int ldb_init(struct mxc_dispdrv_handle *mddh, chan->fbi = fbi; fb_videomode_from_videomode(&chan->vm, &fb_vm); - - INIT_LIST_HEAD(&fbi->modelist); - fb_add_videomode(&fb_vm, &fbi->modelist); fb_videomode_to_var(&fbi->var, &fb_vm); setting->crtc = chan->crtc; |