diff options
| author | Eric Dumazet <edumazet@google.com> | 2019-03-16 13:09:53 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-04-03 06:24:15 +0200 |
| commit | 7b5f260ff73f28143fff4b22aa7067d9a6b22aa4 (patch) | |
| tree | 07807881b0f17442a004440298edfbac012a4b7f /drivers | |
| parent | 6f0f3657ec45944f9204df95f18c97bc875ba1d9 (diff) | |
tun: add a missing rcu_read_unlock() in error path
commit 9180bb4f046064dfa4541488102703b402bb04e1 upstream.
In my latest patch I missed one rcu_read_unlock(), in case
device is down.
Fixes: 4477138fa0ae ("tun: properly test for IFF_UP")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/tun.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/tun.c b/drivers/net/tun.c index c32df13a8630..88fe38d6a7ef 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c @@ -1330,6 +1330,7 @@ drop: rcu_read_lock(); if (unlikely(!(tun->dev->flags & IFF_UP))) { err = -EIO; + rcu_read_unlock(); goto drop; } |