diff options
| author | Simon Horman <simon.horman@netronome.com> | 2015-03-13 11:00:58 +0900 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-03-12 23:23:16 -0400 |
| commit | 719a11cdbf57b7bdd6c87ded00fd7cb36a76a6a3 (patch) | |
| tree | b9a8fa80ece56a2efa30123f79f8bdaf2b2f67ea /drivers | |
| parent | 76fecd8275be6de76513430e7526825944ab932f (diff) | |
vxlan: Don't set s_addr in vxlan_create_sock
In the case of AF_INET s_addr was set to INADDR_ANY (0) which which both
symmetric with the AF_INET6 case, where s_addr is not set, and unnecessary
as udp_conf is zeroed out earlier in the same function.
I suspect this change does not have any run-time effect due to compiler
optimisations. But it does make the code a little easier on the/my eyes.
Cc: Tom Herbert <therbert@google.com>
Signed-off-by: Simon Horman <simon.horman@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/vxlan.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 1e0a775ea882..25d92d4fc625 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -2516,7 +2516,6 @@ static struct socket *vxlan_create_sock(struct net *net, bool ipv6, !(flags & VXLAN_F_UDP_ZERO_CSUM6_RX); } else { udp_conf.family = AF_INET; - udp_conf.local_ip.s_addr = INADDR_ANY; } udp_conf.local_udp_port = port; |