summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorPan Bian <bianpan2016@163.com>2018-11-28 14:53:19 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-12-13 09:21:26 +0100
commit9ab8f8cb2615cf49334dc41fee1dfbce1f450b15 (patch)
tree26029b3c28d6b8181ad5ff6fd8fb1286b1122056 /drivers
parent494fedded2d6404d69c4cf00591b003c06c7afaa (diff)
rapidio/rionet: do not free skb before reading its length
[ Upstream commit cfc435198f53a6fa1f656d98466b24967ff457d0 ] skb is freed via dev_kfree_skb_any, however, skb->len is read then. This may result in a use-after-free bug. Fixes: e6161d64263 ("rapidio/rionet: rework driver initialization and removal") Signed-off-by: Pan Bian <bianpan2016@163.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/net/rionet.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/rionet.c b/drivers/net/rionet.c
index e7034c55e796..6ef9188384ce 100644
--- a/drivers/net/rionet.c
+++ b/drivers/net/rionet.c
@@ -215,9 +215,9 @@ static int rionet_start_xmit(struct sk_buff *skb, struct net_device *ndev)
* it just report sending a packet to the target
* (without actual packet transfer).
*/
- dev_kfree_skb_any(skb);
ndev->stats.tx_packets++;
ndev->stats.tx_bytes += skb->len;
+ dev_kfree_skb_any(skb);
}
}