diff options
| author | Theodore Ts'o <tytso@mit.edu> | 2011-01-10 12:51:28 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-02-17 15:14:20 -0800 |
| commit | 8a249a8e347fb874539af271460ceb54fd29f471 (patch) | |
| tree | 508870927e0bb011baf1bd18e96b160c9cfd6834 /fs/ext4/inode.c | |
| parent | 3d597eb5d470de0073e9e7feaa7413918699579b (diff) | |
ext4: fix memory leak in ext4_free_branches
commit 1c5b9e9065567876c2d4a7a16d78f0fed154a5bf upstream.
Commit 40389687 moved a call to ext4_forget() out of
ext4_free_branches and let ext4_free_blocks() handle calling
bforget(). But that change unfortunately did not replace the call to
ext4_forget() with brelse(), which was needed to drop the in-use count
of the indirect block's buffer head, which lead to a memory leak when
deleting files that used indirect blocks. Fix this.
Thanks to Hugh Dickins for pointing this out.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'fs/ext4/inode.c')
| -rw-r--r-- | fs/ext4/inode.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index e659597b690b..97a28e9d4625 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -4349,6 +4349,7 @@ static void ext4_free_branches(handle_t *handle, struct inode *inode, (__le32 *) bh->b_data, (__le32 *) bh->b_data + addr_per_block, depth); + brelse(bh); /* * Everything below this this pointer has been |