diff options
| author | Fabian Frederick <fabf@skynet.be> | 2014-06-06 14:36:36 -0700 | 
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-06-06 16:08:10 -0700 | 
| commit | a19189e5535ed8fd191d8989fc39da1637cfa224 (patch) | |
| tree | 015539572a32a74d37a72f8ef9dd35c0d9c1a0e0 /fs/hpfs | |
| parent | 1749a10e02a9c6ed1a5c0a2860fb9ed132f2cc42 (diff) | |
fs/hpfs: increase pr_warn level
This patch applies a suggestion by Mikulas Patocka asking to increase
all pr_warn without commented ones to pr_err
Signed-off-by: Fabian Frederick <fabf@skynet.be>
Cc: Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/hpfs')
| -rw-r--r-- | fs/hpfs/buffer.c | 12 | ||||
| -rw-r--r-- | fs/hpfs/dir.c | 2 | ||||
| -rw-r--r-- | fs/hpfs/dnode.c | 24 | ||||
| -rw-r--r-- | fs/hpfs/ea.c | 6 | ||||
| -rw-r--r-- | fs/hpfs/inode.c | 2 | ||||
| -rw-r--r-- | fs/hpfs/map.c | 14 | ||||
| -rw-r--r-- | fs/hpfs/name.c | 6 | ||||
| -rw-r--r-- | fs/hpfs/super.c | 28 | 
8 files changed, 47 insertions, 47 deletions
| diff --git a/fs/hpfs/buffer.c b/fs/hpfs/buffer.c index 07e0b0fc4548..8057fe4e6574 100644 --- a/fs/hpfs/buffer.c +++ b/fs/hpfs/buffer.c @@ -55,7 +55,7 @@ void *hpfs_map_sector(struct super_block *s, unsigned secno, struct buffer_head  	if (bh != NULL)  		return bh->b_data;  	else { -		pr_warn("%s(): read error\n", __func__); +		pr_err("%s(): read error\n", __func__);  		return NULL;  	}  } @@ -76,7 +76,7 @@ void *hpfs_get_sector(struct super_block *s, unsigned secno, struct buffer_head  		set_buffer_uptodate(bh);  		return bh->b_data;  	} else { -		pr_warn("%s(): getblk failed\n", __func__); +		pr_err("%s(): getblk failed\n", __func__);  		return NULL;  	}  } @@ -93,7 +93,7 @@ void *hpfs_map_4sectors(struct super_block *s, unsigned secno, struct quad_buffe  	cond_resched();  	if (secno & 3) { -		pr_warn("%s(): unaligned read\n", __func__); +		pr_err("%s(): unaligned read\n", __func__);  		return NULL;  	} @@ -112,7 +112,7 @@ void *hpfs_map_4sectors(struct super_block *s, unsigned secno, struct quad_buffe  	qbh->data = data = kmalloc(2048, GFP_NOFS);  	if (!data) { -		pr_warn("%s(): out of memory\n", __func__); +		pr_err("%s(): out of memory\n", __func__);  		goto bail4;  	} @@ -145,7 +145,7 @@ void *hpfs_get_4sectors(struct super_block *s, unsigned secno,  	hpfs_lock_assert(s);  	if (secno & 3) { -		pr_warn("%s(): unaligned read\n", __func__); +		pr_err("%s(): unaligned read\n", __func__);  		return NULL;  	} @@ -161,7 +161,7 @@ void *hpfs_get_4sectors(struct super_block *s, unsigned secno,  	}  	if (!(qbh->data = kmalloc(2048, GFP_NOFS))) { -		pr_warn("%s(): out of memory\n", __func__); +		pr_err("%s(): out of memory\n", __func__);  		goto bail4;  	}  	return qbh->data; diff --git a/fs/hpfs/dir.c b/fs/hpfs/dir.c index 3377eba73c13..2a8e07425de0 100644 --- a/fs/hpfs/dir.c +++ b/fs/hpfs/dir.c @@ -127,7 +127,7 @@ static int hpfs_readdir(struct file *file, struct dir_context *ctx)  		if (ctx->pos == 12)  			goto out;  		if (ctx->pos == 3 || ctx->pos == 4 || ctx->pos == 5) { -			pr_warn("pos==%d\n", (int)ctx->pos); +			pr_err("pos==%d\n", (int)ctx->pos);  			goto out;  		}  		if (ctx->pos == 0) { diff --git a/fs/hpfs/dnode.c b/fs/hpfs/dnode.c index d10c5e91c5b2..f36fc010fccb 100644 --- a/fs/hpfs/dnode.c +++ b/fs/hpfs/dnode.c @@ -32,7 +32,7 @@ void hpfs_add_pos(struct inode *inode, loff_t *pos)  			if (hpfs_inode->i_rddir_off[i] == pos) return;  	if (!(i&0x0f)) {  		if (!(ppos = kmalloc((i+0x11) * sizeof(loff_t*), GFP_NOFS))) { -			pr_warn("out of memory for position list\n"); +			pr_err("out of memory for position list\n");  			return;  		}  		if (hpfs_inode->i_rddir_off) { @@ -94,7 +94,7 @@ static void hpfs_pos_ins(loff_t *p, loff_t d, loff_t c)  	if ((*p & ~0x3f) == (d & ~0x3f) && (*p & 0x3f) >= (d & 0x3f)) {  		int n = (*p & 0x3f) + c;  		if (n > 0x3f) -			pr_warn("%s(): %08x + %d\n", +			pr_err("%s(): %08x + %d\n",  				__func__, (int)*p, (int)c >> 8);  		else  			*p = (*p & ~0x3f) | n; @@ -106,7 +106,7 @@ static void hpfs_pos_del(loff_t *p, loff_t d, loff_t c)  	if ((*p & ~0x3f) == (d & ~0x3f) && (*p & 0x3f) >= (d & 0x3f)) {  		int n = (*p & 0x3f) - c;  		if (n < 1) -			pr_warn("%s(): %08x - %d\n", +			pr_err("%s(): %08x - %d\n",  				__func__, (int)*p, (int)c >> 8);  		else  			*p = (*p & ~0x3f) | n; @@ -246,7 +246,7 @@ static int hpfs_add_to_dnode(struct inode *i, dnode_secno dno,  	struct fnode *fnode;  	int c1, c2 = 0;  	if (!(nname = kmalloc(256, GFP_NOFS))) { -		pr_warn("out of memory, can't add to dnode\n"); +		pr_err("out of memory, can't add to dnode\n");  		return 1;  	}  	go_up: @@ -288,7 +288,7 @@ static int hpfs_add_to_dnode(struct inode *i, dnode_secno dno,  		   not be any error while splitting dnodes, otherwise the  		   whole directory, not only file we're adding, would  		   be lost. */ -		pr_warn("out of memory for dnode splitting\n"); +		pr_err("out of memory for dnode splitting\n");  		hpfs_brelse4(&qbh);  		kfree(nname);  		return 1; @@ -604,7 +604,7 @@ static void delete_empty_dnode(struct inode *i, dnode_secno dno)  		if (!de_next->down) goto endm;  		ndown = de_down_pointer(de_next);  		if (!(de_cp = kmalloc(le16_to_cpu(de->length), GFP_NOFS))) { -			pr_warn("out of memory for dtree balancing\n"); +			pr_err("out of memory for dtree balancing\n");  			goto endm;  		}  		memcpy(de_cp, de, le16_to_cpu(de->length)); @@ -645,15 +645,15 @@ static void delete_empty_dnode(struct inode *i, dnode_secno dno)  			if (!dlp && down) {  				if (le32_to_cpu(d1->first_free) > 2044) {  					if (hpfs_sb(i->i_sb)->sb_chk >= 2) { -						pr_warn("unbalanced dnode tree, see hpfs.txt 4 more info\n"); -						pr_warn("terminating balancing operation\n"); +						pr_err("unbalanced dnode tree, see hpfs.txt 4 more info\n"); +						pr_err("terminating balancing operation\n");  					}  					hpfs_brelse4(&qbh1);  					goto endm;  				}  				if (hpfs_sb(i->i_sb)->sb_chk >= 2) { -					pr_warn("unbalanced dnode tree, see hpfs.txt 4 more info\n"); -					pr_warn("goin'on\n"); +					pr_err("unbalanced dnode tree, see hpfs.txt 4 more info\n"); +					pr_err("goin'on\n");  				}  				le16_add_cpu(&del->length, 4);  				del->down = 1; @@ -667,7 +667,7 @@ static void delete_empty_dnode(struct inode *i, dnode_secno dno)  				*(__le32 *) ((void *) del + le16_to_cpu(del->length) - 4) = cpu_to_le32(down);  		} else goto endm;  		if (!(de_cp = kmalloc(le16_to_cpu(de_prev->length), GFP_NOFS))) { -			pr_warn("out of memory for dtree balancing\n"); +			pr_err("out of memory for dtree balancing\n");  			hpfs_brelse4(&qbh1);  			goto endm;  		} @@ -1008,7 +1008,7 @@ struct hpfs_dirent *map_fnode_dirent(struct super_block *s, fnode_secno fno,  	int d1, d2 = 0;  	name1 = f->name;  	if (!(name2 = kmalloc(256, GFP_NOFS))) { -		pr_warn("out of memory, can't map dirent\n"); +		pr_err("out of memory, can't map dirent\n");  		return NULL;  	}  	if (f->len <= 15) diff --git a/fs/hpfs/ea.c b/fs/hpfs/ea.c index 817805975457..ce3f98ba993a 100644 --- a/fs/hpfs/ea.c +++ b/fs/hpfs/ea.c @@ -51,7 +51,7 @@ static char *get_indirect_ea(struct super_block *s, int ano, secno a, int size)  {  	char *ret;  	if (!(ret = kmalloc(size + 1, GFP_NOFS))) { -		pr_warn("out of memory for EA\n"); +		pr_err("out of memory for EA\n");  		return NULL;  	}  	if (hpfs_ea_read(s, a, ano, 0, size, ret)) { @@ -139,7 +139,7 @@ char *hpfs_get_ea(struct super_block *s, struct fnode *fnode, char *key, int *si  			if (ea_indirect(ea))  				return get_indirect_ea(s, ea_in_anode(ea), ea_sec(ea), *size = ea_len(ea));  			if (!(ret = kmalloc((*size = ea_valuelen(ea)) + 1, GFP_NOFS))) { -				pr_warn("out of memory for EA\n"); +				pr_err("out of memory for EA\n");  				return NULL;  			}  			memcpy(ret, ea_data(ea), ea_valuelen(ea)); @@ -165,7 +165,7 @@ char *hpfs_get_ea(struct super_block *s, struct fnode *fnode, char *key, int *si  			if (ea_indirect(ea))  				return get_indirect_ea(s, ea_in_anode(ea), ea_sec(ea), *size = ea_len(ea));  			if (!(ret = kmalloc((*size = ea_valuelen(ea)) + 1, GFP_NOFS))) { -				pr_warn("out of memory for EA\n"); +				pr_err("out of memory for EA\n");  				return NULL;  			}  			if (hpfs_ea_read(s, a, ano, pos + 4 + ea->namelen + 1, ea_valuelen(ea), ret)) { diff --git a/fs/hpfs/inode.c b/fs/hpfs/inode.c index 89e5a0b75ea7..7ce4b74234a1 100644 --- a/fs/hpfs/inode.c +++ b/fs/hpfs/inode.c @@ -184,7 +184,7 @@ void hpfs_write_inode(struct inode *i)  	if (i->i_ino == hpfs_sb(i->i_sb)->sb_root) return;  	if (hpfs_inode->i_rddir_off && !atomic_read(&i->i_count)) {  		if (*hpfs_inode->i_rddir_off) -			pr_warn("write_inode: some position still there\n"); +			pr_err("write_inode: some position still there\n");  		kfree(hpfs_inode->i_rddir_off);  		hpfs_inode->i_rddir_off = NULL;  	} diff --git a/fs/hpfs/map.c b/fs/hpfs/map.c index 6ac8f7a74efc..442770edcdc7 100644 --- a/fs/hpfs/map.c +++ b/fs/hpfs/map.c @@ -65,13 +65,13 @@ unsigned char *hpfs_load_code_page(struct super_block *s, secno cps)  	struct code_page_directory *cp = hpfs_map_sector(s, cps, &bh, 0);  	if (!cp) return NULL;  	if (le32_to_cpu(cp->magic) != CP_DIR_MAGIC) { -		pr_warn("Code page directory magic doesn't match (magic = %08x)\n", +		pr_err("Code page directory magic doesn't match (magic = %08x)\n",  			le32_to_cpu(cp->magic));  		brelse(bh);  		return NULL;  	}  	if (!le32_to_cpu(cp->n_code_pages)) { -		pr_warn("n_code_pages == 0\n"); +		pr_err("n_code_pages == 0\n");  		brelse(bh);  		return NULL;  	} @@ -80,19 +80,19 @@ unsigned char *hpfs_load_code_page(struct super_block *s, secno cps)  	brelse(bh);  	if (cpi >= 3) { -		pr_warn("Code page index out of array\n"); +		pr_err("Code page index out of array\n");  		return NULL;  	}  	if (!(cpd = hpfs_map_sector(s, cpds, &bh, 0))) return NULL;  	if (le16_to_cpu(cpd->offs[cpi]) > 0x178) { -		pr_warn("Code page index out of sector\n"); +		pr_err("Code page index out of sector\n");  		brelse(bh);  		return NULL;  	}  	ptr = (unsigned char *)cpd + le16_to_cpu(cpd->offs[cpi]) + 6;  	if (!(cp_table = kmalloc(256, GFP_KERNEL))) { -		pr_warn("out of memory for code page table\n"); +		pr_err("out of memory for code page table\n");  		brelse(bh);  		return NULL;  	} @@ -115,7 +115,7 @@ __le32 *hpfs_load_bitmap_directory(struct super_block *s, secno bmp)  	int i;  	__le32 *b;  	if (!(b = kmalloc(n * 512, GFP_KERNEL))) { -		pr_warn("can't allocate memory for bitmap directory\n"); +		pr_err("can't allocate memory for bitmap directory\n");  		return NULL;  	}	  	for (i=0;i<n;i++) { @@ -283,7 +283,7 @@ struct dnode *hpfs_map_dnode(struct super_block *s, unsigned secno,  				goto bail;  			}  			if (b == 3) -				pr_warn("unbalanced dnode tree, dnode %08x; see hpfs.txt 4 more info\n", +				pr_err("unbalanced dnode tree, dnode %08x; see hpfs.txt 4 more info\n",  					secno);  		}  	return dnode; diff --git a/fs/hpfs/name.c b/fs/hpfs/name.c index 91f4cc172e38..b00d396d22c6 100644 --- a/fs/hpfs/name.c +++ b/fs/hpfs/name.c @@ -56,15 +56,15 @@ unsigned char *hpfs_translate_name(struct super_block *s, unsigned char *from,  	unsigned char *to;  	int i;  	if (hpfs_sb(s)->sb_chk >= 2) if (hpfs_is_name_long(from, len) != lng) { -		pr_warn("Long name flag mismatch - name "); +		pr_err("Long name flag mismatch - name ");  		for (i = 0; i < len; i++)  			pr_cont("%c", from[i]);  		pr_cont(" misidentified as %s.\n", lng ? "short" : "long"); -		pr_warn("It's nothing serious. It could happen because of bug in OS/2.\nSet checks=normal to disable this message.\n"); +		pr_err("It's nothing serious. It could happen because of bug in OS/2.\nSet checks=normal to disable this message.\n");  	}  	if (!lc) return from;  	if (!(to = kmalloc(len, GFP_KERNEL))) { -		pr_warn("can't allocate memory for name conversion buffer\n"); +		pr_err("can't allocate memory for name conversion buffer\n");  		return from;  	}  	for (i = 0; i < len; i++) to[i] = locase(hpfs_sb(s)->sb_cp_table,from[i]); diff --git a/fs/hpfs/super.c b/fs/hpfs/super.c index 92fd3cebeba4..7cd00d3a7c9b 100644 --- a/fs/hpfs/super.c +++ b/fs/hpfs/super.c @@ -438,7 +438,7 @@ static int hpfs_remount_fs(struct super_block *s, int *flags, char *data)  	if (!(o = parse_opts(data, &uid, &gid, &umask, &lowercase,  	    &eas, &chk, &errs, &chkdsk, ×hift))) { -		pr_warn("bad mount options.\n"); +		pr_err("bad mount options.\n");  		goto out_err;  	}  	if (o == 2) { @@ -446,7 +446,7 @@ static int hpfs_remount_fs(struct super_block *s, int *flags, char *data)  		goto out_err;  	}  	if (timeshift != sbi->sb_timeshift) { -		pr_warn("timeshift can't be changed using remount.\n"); +		pr_err("timeshift can't be changed using remount.\n");  		goto out_err;  	} @@ -527,7 +527,7 @@ static int hpfs_fill_super(struct super_block *s, void *options, int silent)  	if (!(o = parse_opts(options, &uid, &gid, &umask, &lowercase,  	    &eas, &chk, &errs, &chkdsk, ×hift))) { -		pr_warn("bad mount options.\n"); +		pr_err("bad mount options.\n");  		goto bail0;  	}  	if (o==2) { @@ -547,16 +547,16 @@ static int hpfs_fill_super(struct super_block *s, void *options, int silent)  	    ||*/ le32_to_cpu(superblock->magic) != SB_MAGIC  	    || le32_to_cpu(spareblock->magic) != SP_MAGIC) {  		if (!silent) -			pr_warn("Bad magic ... probably not HPFS\n"); +			pr_err("Bad magic ... probably not HPFS\n");  		goto bail4;  	}  	/* Check version */  	if (!(s->s_flags & MS_RDONLY) &&  	      superblock->funcversion != 2 && superblock->funcversion != 3) { -		pr_warn("Bad version %d,%d. Mount readonly to go around\n", +		pr_err("Bad version %d,%d. Mount readonly to go around\n",  			(int)superblock->version, (int)superblock->funcversion); -		pr_warn("please try recent version of HPFS driver at http://artax.karlin.mff.cuni.cz/~mikulas/vyplody/hpfs/index-e.cgi and if it still can't understand this format, contact author - mikulas@artax.karlin.mff.cuni.cz\n"); +		pr_err("please try recent version of HPFS driver at http://artax.karlin.mff.cuni.cz/~mikulas/vyplody/hpfs/index-e.cgi and if it still can't understand this format, contact author - mikulas@artax.karlin.mff.cuni.cz\n");  		goto bail4;  	} @@ -602,7 +602,7 @@ static int hpfs_fill_super(struct super_block *s, void *options, int silent)  	/* Check for general fs errors*/  	if (spareblock->dirty && !spareblock->old_wrote) {  		if (errs == 2) { -			pr_warn("Improperly stopped, not mounted\n"); +			pr_err("Improperly stopped, not mounted\n");  			goto bail4;  		}  		hpfs_error(s, "improperly stopped"); @@ -616,25 +616,25 @@ static int hpfs_fill_super(struct super_block *s, void *options, int silent)  	if (spareblock->hotfixes_used || spareblock->n_spares_used) {  		if (errs >= 2) { -			pr_warn("Hotfixes not supported here, try chkdsk\n"); +			pr_err("Hotfixes not supported here, try chkdsk\n");  			mark_dirty(s, 0);  			goto bail4;  		}  		hpfs_error(s, "hotfixes not supported here, try chkdsk");  		if (errs == 0) -			pr_warn("Proceeding, but your filesystem will be probably corrupted by this driver...\n"); +			pr_err("Proceeding, but your filesystem will be probably corrupted by this driver...\n");  		else -			pr_warn("This driver may read bad files or crash when operating on disk with hotfixes.\n"); +			pr_err("This driver may read bad files or crash when operating on disk with hotfixes.\n");  	}  	if (le32_to_cpu(spareblock->n_dnode_spares) != le32_to_cpu(spareblock->n_dnode_spares_free)) {  		if (errs >= 2) { -			pr_warn("Spare dnodes used, try chkdsk\n"); +			pr_err("Spare dnodes used, try chkdsk\n");  			mark_dirty(s, 0);  			goto bail4;  		}  		hpfs_error(s, "warning: spare dnodes used, try chkdsk");  		if (errs == 0) -			pr_warn("Proceeding, but your filesystem could be corrupted if you delete files or directories\n"); +			pr_err("Proceeding, but your filesystem could be corrupted if you delete files or directories\n");  	}  	if (chk) {  		unsigned a; @@ -654,12 +654,12 @@ static int hpfs_fill_super(struct super_block *s, void *options, int silent)  		}  		sbi->sb_dirband_size = a;  	} else -		pr_warn("You really don't want any checks? You are crazy...\n"); +		pr_err("You really don't want any checks? You are crazy...\n");  	/* Load code page table */  	if (le32_to_cpu(spareblock->n_code_pages))  		if (!(sbi->sb_cp_table = hpfs_load_code_page(s, le32_to_cpu(spareblock->code_page_dir)))) -			pr_warn("code page support is disabled\n"); +			pr_err("code page support is disabled\n");  	brelse(bh2);  	brelse(bh1); | 
