diff options
| author | Oleg Nesterov <oleg@tv-sign.ru> | 2006-08-21 08:33:23 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@suse.de> | 2006-08-21 08:33:23 +0200 |
| commit | 78bd4d484f81a611ef6ff02f909e576cb9aac7f2 (patch) | |
| tree | 9ba30e54a16d47b3cf4a9ea0123f7261d52462ab /fs/ioprio.c | |
| parent | ef7d1b244fa6c94fb76d5f787b8629df64ea4046 (diff) | |
[PATCH] sys_ioprio_set: minor do_each_thread+break fix
From include/linux/sched.h:
* Careful: do_each_thread/while_each_thread is a double loop so
* 'break' will not work as expected - use goto instead.
*/
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: Jens Axboe <axboe@suse.de>
Diffstat (limited to 'fs/ioprio.c')
| -rw-r--r-- | fs/ioprio.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/ioprio.c b/fs/ioprio.c index 93aa5715f224..3db31038e9ab 100644 --- a/fs/ioprio.c +++ b/fs/ioprio.c @@ -111,9 +111,9 @@ asmlinkage long sys_ioprio_set(int which, int who, int ioprio) continue; ret = set_task_ioprio(p, ioprio); if (ret) - break; + goto free_uid; } while_each_thread(g, p); - +free_uid: if (who) free_uid(user); break; |