summaryrefslogtreecommitdiff
path: root/fs/ncpfs/Makefile
diff options
context:
space:
mode:
authorSerge Hallyn <serge@hallyn.com>2008-02-29 15:14:57 +0000
committerChris Wright <chrisw@sous-sol.org>2008-04-18 18:53:30 -0700
commit44996dccd89ce86c7c38e37e0635d30c66279772 (patch)
tree6c07faa687a71f06d0e1454c305543f5c059bb58 /fs/ncpfs/Makefile
parentd7d835ba45a0a2b30ed47887275e271e9ddddbdb (diff)
file capabilities: remove cap_task_kill()
upstream commit: aedb60a67c10a0861af179725d060765262ba0fb The original justification for cap_task_kill() was as follows: check_kill_permission() does appropriate uid equivalence checks. However with file capabilities it becomes possible for an unprivileged user to execute a file with file capabilities resulting in a more privileged task with the same uid. However now that cap_task_kill() always returns 0 (permission granted) when p->uid==current->uid, the whole hook is worthless, and only likely to create more subtle problems in the corner cases where it might still be called but return -EPERM. Those cases are basically when uids are different but euid/suid is equivalent as per the check in check_kill_permission(). One example of a still-broken application is 'at' for non-root users. This patch removes cap_task_kill(). Signed-off-by: Serge Hallyn <serge@hallyn.com> Acked-by: Andrew G. Morgan <morgan@kernel.org> Earlier-version-tested-by: Luiz Fernando N. Capitulino <lcapitulino@mandriva.com.br> Acked-by: Casey Schaufler <casey@schaufler-ca.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> [chrisw@sous-sol.org: backport to 2.6.24.4] Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Diffstat (limited to 'fs/ncpfs/Makefile')
0 files changed, 0 insertions, 0 deletions