summaryrefslogtreecommitdiff
path: root/fs/xattr_acl.c
diff options
context:
space:
mode:
authorDave Chinner <dchinner@redhat.com>2011-11-19 13:13:40 -0500
committerGreg Kroah-Hartman <gregkh@suse.de>2011-11-26 09:10:05 -0800
commit16ba92e591d31d3213956e581867f46892648038 (patch)
tree60eb2e93d8edbdc1397ad805e47a17f237e10199 /fs/xattr_acl.c
parentafd717d6cd334fc89f3ac938e19aade2f939b629 (diff)
xfs: dont serialise direct IO reads on page cache
commit 0c38a2512df272b14ef4238b476a2e4f70da1479 upstream. There is no need to grab the i_mutex of the IO lock in exclusive mode if we don't need to invalidate the page cache. Taking these locks on every direct IO effective serialises them as taking the IO lock in exclusive mode has to wait for all shared holders to drop the lock. That only happens when IO is complete, so effective it prevents dispatch of concurrent direct IO reads to the same inode. Fix this by taking the IO lock shared to check the page cache state, and only then drop it and take the IO lock exclusively if there is work to be done. Hence for the normal direct IO case, no exclusive locking will occur. Signed-off-by: Dave Chinner <dchinner@redhat.com> Tested-by: Joern Engel <joern@logfs.org> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Alex Elder <aelder@sgi.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'fs/xattr_acl.c')
0 files changed, 0 insertions, 0 deletions