summaryrefslogtreecommitdiff
path: root/fs/xfs/xfs_xattr.c
diff options
context:
space:
mode:
authorDave Chinner <dchinner@redhat.com>2013-06-12 12:19:06 +1000
committerBen Myers <bpm@sgi.com>2013-06-14 15:59:45 -0500
commitd302cf1d316dca5f567e89872cf5d475c9a55f74 (patch)
tree63912ef184e6494b6a810290e1d706aeef1da8a2 /fs/xfs/xfs_xattr.c
parent088c9f67c3f53339d2bc20b42a9cb904901fdc5d (diff)
xfs: don't shutdown log recovery on validation errors
Unfortunately, we cannot guarantee that items logged multiple times and replayed by log recovery do not take objects back in time. When they are taken back in time, the go into an intermediate state which is corrupt, and hence verification that occurs on this intermediate state causes log recovery to abort with a corruption shutdown. Instead of causing a shutdown and unmountable filesystem, don't verify post-recovery items before they are written to disk. This is less than optimal, but there is no way to detect this issue for non-CRC filesystems If log recovery successfully completes, this will be undone and the object will be consistent by subsequent transactions that are replayed, so in most cases we don't need to take drastic action. For CRC enabled filesystems, leave the verifiers in place - we need to call them to recalculate the CRCs on the objects anyway. This recovery problem can be solved for such filesystems - we have a LSN stamped in all metadata at writeback time that we can to determine whether the item should be replayed or not. This is a separate piece of work, so is not addressed by this patch. Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Ben Myers <bpm@sgi.com> Signed-off-by: Ben Myers <bpm@sgi.com> (cherry picked from commit 9222a9cf86c0d64ffbedf567412b55da18763aa3)
Diffstat (limited to 'fs/xfs/xfs_xattr.c')
0 files changed, 0 insertions, 0 deletions