summaryrefslogtreecommitdiff
path: root/fs
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2016-10-20 15:49:03 +1100
committerDave Chinner <david@fromorbit.com>2016-10-20 15:49:03 +1100
commita62e82b35b97e60e9e22a4e303900f342139822f (patch)
tree59cb362b3750845f992dd70f578ddcacda986bac /fs
parent4fbc2c65255f77b315a4ee3ccac397d677a35737 (diff)
xfs: fix the same_inode check in xfs_file_share_range
The VFS i_ino is an unsigned long, while XFS inode numbers are 64-bit wide, so checking i_ino for equality could lead to rate false positives on 32-bit architectures. Just compare the inode pointers themselves to be safe. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: Dave Chinner <david@fromorbit.com>
Diffstat (limited to 'fs')
-rw-r--r--fs/xfs/xfs_file.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index 194f8f396e4d..d5b835e82b2d 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -965,7 +965,7 @@ xfs_file_share_range(
IS_SWAPFILE(inode_out))
return -ETXTBSY;
- same_inode = (inode_in->i_ino == inode_out->i_ino);
+ same_inode = (inode_in == inode_out);
/* Don't reflink dirs, pipes, sockets... */
if (S_ISDIR(inode_in->i_mode) || S_ISDIR(inode_out->i_mode))