diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2015-11-20 22:48:36 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-02-25 11:03:47 +0100 |
| commit | ac21d006fcfd3e1faaef9ab4cf492f056cb0aa88 (patch) | |
| tree | 0f0c7c1a913a4bb4d8a9d3cec35a422cb4d92879 /include/linux/bug.h | |
| parent | 3f488a9fd5c088e67b9f4865a96db0cf1d8c3790 (diff) | |
fbdev: sm712fb: avoid unused function warnings
commit 24ed78dc2e8b2428eccc70c3162e70d33ab448c4 upstream.
The sm712fb framebuffer driver encloses the power-management
functions in #ifdef CONFIG_PM, but the smtcfb_pci_suspend/resume
functions are only really used when CONFIG_PM_SLEEP is also
set, as a frequent gcc warning shows:
fbdev/sm712fb.c:1549:12: warning: 'smtcfb_pci_suspend' defined but not used
fbdev/sm712fb.c:1572:12: warning: 'smtcfb_pci_resume' defined but not used
The driver also avoids using the SIMPLE_DEV_PM_OPS macro when
CONFIG_PM is unset, which is redundant.
This changes the driver to remove the #ifdef and instead mark
the functions as __maybe_unused, which is a nicer anyway, as it
provides build testing for all the code in all configurations
and is harder to get wrong.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/linux/bug.h')
0 files changed, 0 insertions, 0 deletions