diff options
author | Oleg Nesterov <oleg@redhat.com> | 2015-11-15 20:33:14 +0100 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2015-11-23 09:48:18 +0100 |
commit | 6a19005157c464b47b2082f2617d12bc11198a0d (patch) | |
tree | 90b75567427d005de8b2032fe2005cd08153f40c /include/linux/stop_machine.h | |
parent | 64038f292a1b33c7d46bd11f62f7798101152c00 (diff) |
stop_machine: Don't disable preemption in stop_two_cpus()
Now that stop_two_cpus() path does not check cpu_active() we can remove
preempt_disable(), it was only needed to ensure that stop_machine() can
not be called after we observe cpu_active() == T and before we queue the
new work.
Also, turn the pointless and confusing ->executed check into WARN_ON().
We know that both works must be executed, otherwise we have a bug. And
in fact I think that done->executed should die, see the next changes.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Tejun Heo <tj@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Milos Vyletel <milos@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Prarit Bhargava <prarit@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20151115193314.GA8249@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'include/linux/stop_machine.h')
0 files changed, 0 insertions, 0 deletions